Skip to content

Fix locale message typo#17726

Merged
JackieTien97 merged 1 commit into
masterfrom
ty/fixTypo
May 20, 2026
Merged

Fix locale message typo#17726
JackieTien97 merged 1 commit into
masterfrom
ty/fixTypo

Conversation

@JackieTien97
Copy link
Copy Markdown
Contributor

This pull request improves the error messages thrown for invalid (negative) parameter values in the PatternMatchTableFunction by formatting them with the actual invalid value, making the messages clearer and more informative.

Error handling improvements:

  • Updated all error messages for negative parameter values (smooth, threshold, width, height) to use String.format for including the actual invalid value in the exception message instead of simple string concatenation. (iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/plan/relational/function/tvf/PatternMatchTableFunction.java)

@sonarqubecloud
Copy link
Copy Markdown

@JackieTien97 JackieTien97 merged commit df7e92a into master May 20, 2026
43 checks passed
@JackieTien97 JackieTien97 deleted the ty/fixTypo branch May 20, 2026 04:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.42%. Comparing base (34cc346) to head (c3cb7a7).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...tional/function/tvf/PatternMatchTableFunction.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             master   #17726    +/-   ##
==========================================
  Coverage     40.41%   40.42%            
  Complexity     2574     2574            
==========================================
  Files          5179     5179            
  Lines        349767   349896   +129     
  Branches      44714    44727    +13     
==========================================
+ Hits         141373   141446    +73     
- Misses       208394   208450    +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant